[
https://issues.apache.org/jira/browse/HBASE-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161107#comment-14161107
]
Hadoop QA commented on HBASE-11815:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12673157/HBASE-11815_2.patch
against trunk revision .
ATTACHMENT ID: 12673157
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11226//console
This message is automatically generated.
> Flush and compaction could just close the tmp writer if there is an exception
> -----------------------------------------------------------------------------
>
> Key: HBASE-11815
> URL: https://issues.apache.org/jira/browse/HBASE-11815
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Trivial
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11815.patch, HBASE-11815_0.98.patch,
> HBASE-11815_1.patch, HBASE-11815_2.patch, HBASE-11815_2.patch
>
>
> A minor change.
> {code}
> try {
> flushed = performFlush(scanner, writer, smallestReadPoint);
> } finally {
> finalizeWriter(writer, cacheFlushId, status);
> }
> {code}
> Whenever there is a failure during flush we should close the writer but
> adding the meta data and setting the status would not be needed.
> {code}
> status.setStatus("Flushing " + store + ": appending metadata");
> writer.appendMetadata(cacheFlushSeqNum, false);
> status.setStatus("Flushing " + store + ": closing flushed file");
> writer.close();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
