[ https://issues.apache.org/jira/browse/HBASE-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Misty Stanley-Jones resolved HBASE-11937. ----------------------------------------- Resolution: Duplicate > Update patch submission guidelines to stop using --no-prefix > ------------------------------------------------------------ > > Key: HBASE-11937 > URL: https://issues.apache.org/jira/browse/HBASE-11937 > Project: HBase > Issue Type: Improvement > Components: documentation > Reporter: Sean Busbey > Assignee: Misty Stanley-Jones > Priority: Minor > > Right now the submission guidelines include the use of --no-prefix in the > Methods to Create Patches section: > {quote} > Git > git format-patch is preferred because it preserves commit messages. Use git > squash first, to combine smaller commits into a single larger one. > * git format-patch --no-prefix origin/master --stdout > HBASE-XXXX.patch > * git diff --no-prefix origin/master > HBASE-XXXX.patch > {quote} > The use of --no-prefix means that users of {{git apply}} and {{git am}} have > to know to specify {{-p0}} and (which strips 0 levels of prefix). Both of > those tools default to stripping the 1 level of prefix git makes by default. > The guide for HBase committers section on reviewing doesn't give any > suggestions on how to apply patches from contributors. It should probably > give examples for using {{git am}} and {{git apply}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)