[ 
https://issues.apache.org/jira/browse/HBASE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098391#comment-13098391
 ] 

Lars Hofhansl commented on HBASE-2195:
--------------------------------------

ReadFields is documented at the interface level (whether it is internally 
versioned should be of no interest to callers).

Subclassing VersionedWritable has no advantage here (we can't use 
super.readFields nor super.write), so I'd rather not leak the versioning stuff 
out of HLogKey via a getVersion() method until we need it.

My main concern is w.r.t. the changes to HRegion, because that now has the 
cluster UUID sprinkled all over.

All tests pass now, and I did some manual testing with a colleague here at 
Salesforce.com in a Master-Master setting, I'll setup a formal review now so we 
can target the comments better.


> Support cyclic replication
> --------------------------
>
>                 Key: HBASE-2195
>                 URL: https://issues.apache.org/jira/browse/HBASE-2195
>             Project: HBase
>          Issue Type: Sub-task
>          Components: replication
>            Reporter: Jean-Daniel Cryans
>            Assignee: Lars Hofhansl
>         Attachments: 2195-v5.txt, 2195-v6.txt, 2195.txt
>
>
> We need to support cyclic replication by using the cluster id of each HlogKey 
> and stop replicating when it goes back to the original cluster.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to