[ https://issues.apache.org/jira/browse/HBASE-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166127#comment-14166127 ]
Hadoop QA commented on HBASE-12075: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12674051/0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch against trunk revision . ATTACHMENT ID: 12674051 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + public void testPreemptiveFastFailException20Times() throws InterruptedException, ExecutionException { + priviCallerNew.callWithRetries(getRetryingCallable(serverName, null, true), CLEANUP_TIMEOUT); + Thread.sleep(10); // Sleep a ms so that we don't outrun the priviThread. Hope its enough. Fingers crossed {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.master.TestMasterNoCluster.testNotPullingDeadRegionServerFromZK(TestMasterNoCluster.java:306) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11298//console This message is automatically generated. > Preemptive Fast Fail > -------------------- > > Key: HBASE-12075 > URL: https://issues.apache.org/jira/browse/HBASE-12075 > Project: HBase > Issue Type: Sub-task > Components: Client > Affects Versions: 0.99.0, 2.0.0, 0.98.6.1 > Reporter: Manukranth Kolloju > Assignee: Manukranth Kolloju > Attachments: 0001-Add-a-test-case-for-Preemptive-Fast-Fail.patch, > 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch, > 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch, > 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch, > 0001-Implement-Preemptive-Fast-Fail.patch, > 0001-Implement-Preemptive-Fast-Fail.patch, > 0001-Implement-Preemptive-Fast-Fail.patch, > 0001-Implement-Preemptive-Fast-Fail.patch, > 0001-Implement-Preemptive-Fast-Fail.patch > > > In multi threaded clients, we use a feature developed on 0.89-fb branch > called Preemptive Fast Fail. This allows the client threads which would > potentially fail, fail fast. The idea behind this feature is that we allow, > among the hundreds of client threads, one thread to try and establish > connection with the regionserver and if that succeeds, we mark it as a live > node again. Meanwhile, other threads which are trying to establish connection > to the same server would ideally go into the timeouts which is effectively > unfruitful. We can in those cases return appropriate exceptions to those > clients instead of letting them retry. -- This message was sent by Atlassian JIRA (v6.3.4#6332)