[
https://issues.apache.org/jira/browse/HBASE-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172931#comment-14172931
]
Hadoop QA commented on HBASE-12269:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675094/HBASE-12269-2014-10-15-v1.patch
against trunk revision .
ATTACHMENT ID: 12675094
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private _Fields optionals[] =
{_Fields.START_ROW,_Fields.STOP_ROW,_Fields.TIMESTAMP,_Fields.COLUMNS,_Fields.CACHING,_Fields.FILTER_STRING,_Fields.BATCH_SIZE,_Fields.SORT_COLUMNS,_Fields.REVERSED,_Fields.ROW_PREFIX_FILTER};
+ setRowPrefixFilter(rowPrefixFilter == null ? (ByteBuffer)null :
ByteBuffer.wrap(rowPrefixFilter));
+ /** Returns true if field rowPrefixFilter is set (has been assigned a value)
and false otherwise */
+ lastComparison =
Boolean.valueOf(isSetRowPrefixFilter()).compareTo(typedOther.isSetRowPrefixFilter());
+ lastComparison =
Boolean.valueOf(isSetAuthorizations()).compareTo(typedOther.isSetAuthorizations());
+ lastComparison =
Boolean.valueOf(isSetCellVisibility()).compareTo(typedOther.isSetCellVisibility());
+ private _Fields optionals[] =
{_Fields.START_ROW,_Fields.STOP_ROW,_Fields.COLUMNS,_Fields.CACHING,_Fields.MAX_VERSIONS,_Fields.TIME_RANGE,_Fields.FILTER_STRING,_Fields.BATCH_SIZE,_Fields.ATTRIBUTES,_Fields.AUTHORIZATIONS,_Fields.REVERSED,_Fields.ROW_PREFIX_FILTER};
+ setRowPrefixFilter(rowPrefixFilter == null ? (ByteBuffer)null :
ByteBuffer.wrap(rowPrefixFilter));
+ /** Returns true if field rowPrefixFilter is set (has been assigned a value)
and false otherwise */
+ lastComparison =
Boolean.valueOf(isSetAuthorizations()).compareTo(typedOther.isSetAuthorizations());
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11362//console
This message is automatically generated.
> Add support for Scan.setRowPrefixFilter to thrift
> -------------------------------------------------
>
> Key: HBASE-12269
> URL: https://issues.apache.org/jira/browse/HBASE-12269
> Project: HBase
> Issue Type: New Feature
> Components: Thrift
> Reporter: Niels Basjes
> Attachments: HBASE-12269-2014-10-15-v1.patch
>
>
> I think having the feature introduced in HBASE-11990 in the hbase thrift
> interface would be very useful.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
