[ 
https://issues.apache.org/jira/browse/HBASE-12277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173334#comment-14173334
 ] 

Hadoop QA commented on HBASE-12277:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12675200/0002-HBASE-12277-License-text-added-to-the-newly-created-.patch
  against trunk revision .
  ATTACHMENT ID: 12675200

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11371//console

This message is automatically generated.

> Refactor bulkLoad methods in AccessController to its own interface
> ------------------------------------------------------------------
>
>                 Key: HBASE-12277
>                 URL: https://issues.apache.org/jira/browse/HBASE-12277
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Madhan Neethiraj
>         Attachments: 
> 0001-HBASE-12277-Refactored-bulk-load-methods-from-Access.patch, 
> 0002-HBASE-12277-License-text-added-to-the-newly-created-.patch
>
>
> SecureBulkLoadEndPoint references couple of methods, prePrepareBulkLoad() and 
> preCleanupBulkLoad(), implemented in AccessController i.e. direct coupling 
> between AccessController and SecureBuikLoadEndPoint classes.
> SecureBulkLoadEndPoint assumes presence of AccessController in 
> secure-cluster. If HBase is configured with another coprocessor for 
> access-control, SecureBulkLoadEndPoint fails with NPE.
> To remove this direct coupling, bulk-load related methods in AccessController 
> should be refactored to an interface; and have AccessController implement 
> this interfaces. SecureBulkLoadEndPoint should then look for coprocessors 
> that implement this interface, instead of directly looking for 
> AccessController.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to