[ https://issues.apache.org/jira/browse/HBASE-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180412#comment-14180412 ]
Hadoop QA commented on HBASE-12313: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12676392/0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch against trunk revision . ATTACHMENT ID: 12676392 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 40 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:red}-1 javac{color}. The applied patch generated 3812 checkstyle errors (more than the trunk's current 3810 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + FSReaderImpl(FSDataInputStream istream, long fileSize, HFileContext fileContext) throws IOException { + HFileBlock.FSReaderImpl fsBlockReaderV2 = new HFileBlock.FSReaderImpl(fsdis, fileSize, hfs, path, + HFileBlock.FSReaderImpl hbr = new HFileBlock.FSReaderImpl(new FSDataInputStreamWrapper(is), {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.http.TestHttpServer org.apache.hadoop.hbase.io.hfile.TestSeekTo Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/patchReleaseAuditWarnings.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11442//console This message is automatically generated. > Redo the hfile index length optimization so cell-based rather than serialized > KV key > ------------------------------------------------------------------------------------ > > Key: HBASE-12313 > URL: https://issues.apache.org/jira/browse/HBASE-12313 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Reporter: stack > Assignee: stack > Attachments: > 0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch, > 0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch, > 0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch > > > Trying to remove API that returns the 'key' of a KV serialized into a byte > array is thorny. > I tried to move over the first and last key serializations and the hfile > index entries to be cell but patch was turning massive. Here is a smaller > patch that just redoes the optimization that tries to find 'short' midpoints > between last key of last block and first key of next block so it is > Cell-based rather than byte array based (presuming Keys serialized in a > certain way). Adds unit tests which we didn't have before. > Also remove CellKey. Not needed... at least not yet. Its just utility for > toString. -- This message was sent by Atlassian JIRA (v6.3.4#6332)