[ https://issues.apache.org/jira/browse/HBASE-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183890#comment-14183890 ]
Hudson commented on HBASE-11912: -------------------------------- FAILURE: Integrated in HBase-TRUNK #5699 (See [https://builds.apache.org/job/HBase-TRUNK/5699/]) HBASE-11912 Catch some bad practices at compile time with error-prone (apurtell: rev 7ed0260eff425e7e7a57193a67419fae29aa4f30) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java * hbase-shell/pom.xml * hbase-prefix-tree/pom.xml * hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/keyvalue/TestKeyValueTool.java * hbase-client/pom.xml * hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java * hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTableWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java * hbase-thrift/pom.xml * hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestRowData.java * pom.xml * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/HTablePool.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/HbckTestingUtil.java * hbase-hadoop2-compat/pom.xml * hbase-common/pom.xml * hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java * hbase-hadoop-compat/pom.xml * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterCoprocessorExceptionWithAbort.java * hbase-examples/pom.xml * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java * hbase-it/pom.xml * hbase-server/pom.xml > Catch some bad practices at compile time with error-prone > --------------------------------------------------------- > > Key: HBASE-11912 > URL: https://issues.apache.org/jira/browse/HBASE-11912 > Project: HBase > Issue Type: Sub-task > Reporter: Andrew Purtell > Attachments: HBASE-11912.patch, HBASE-11912.patch, HBASE-11912.patch > > > Google's error-prone (https://code.google.com/p/error-prone/) wraps javac > with some additional static analysis that will generate additional warnings > or errors at compile time if certain bug patterns > (https://code.google.com/p/error-prone/wiki/BugPatterns) are detected. What's > nice about this approach, as opposed to findbugs, is the compile time > detection and erroring out prevent the detected problems from getting into > the codebase up front. -- This message was sent by Atlassian JIRA (v6.3.4#6332)