[ https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-12392: ------------------------------------------- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Committed to HBASE-11339. Thanks for the patch Jingcheng. > Incorrect implementation of CompactionRequest.isRetainDeleteMarkers > ------------------------------------------------------------------- > > Key: HBASE-12392 > URL: https://issues.apache.org/jira/browse/HBASE-12392 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Affects Versions: hbase-11339 > Reporter: Jingcheng Du > Assignee: Jingcheng Du > Priority: Critical > Fix For: hbase-11339 > > Attachments: HBASE-12392.diff > > > Now in the implementation of the isRetainDeleteMarkers method, the code look > like, > {code} > return (this.retainDeleteMarkers != null) ? > this.retainDeleteMarkers.booleanValue() > : isAllFiles(); > {code} > It means for a major compaction in a normal store, this method returns true. > Consequently the delete marks could not be deleted in the major compaction, > which leads the unit test TestKeepDeletes fails. > The correct implementation should be, > {code} > return (this.retainDeleteMarkers != null) ? > this.retainDeleteMarkers.booleanValue() > : !isAllFiles(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)