[
https://issues.apache.org/jira/browse/HBASE-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193208#comment-14193208
]
ChiaPing Tsai commented on HBASE-12393:
---------------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
Not added any UT as it was only message change on UI.
The manual steps are shown below:
# set hfile.block.cache.size to zero.
# open the RegionServer UI and there are no nullpointexception anymore.
# click on "Stats of Block Cache" and the message "Block Cache is disabled"
will appear
{quote}
-1 checkstyle. The applied patch generated 3782 checkstyle errors (more than
the trunk's current 3781 errors).
{quote}
The BlockCacheTmplImpl.java is the auto-generated Jamon implementation. The
white space error is due to the code style of Jamon.
> The regionserver web will throw exception if we disable block cache
> -------------------------------------------------------------------
>
> Key: HBASE-12393
> URL: https://issues.apache.org/jira/browse/HBASE-12393
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.98.7
> Environment: ubuntu 12.04 64bits, hadoop-2.2.0, hbase-0.98.7-hadoop2
> Reporter: ChiaPing Tsai
> Priority: Minor
> Labels: patch
> Attachments: HBASE-12393.patch
>
>
> The CacheConfig.getBlockCache() will return the null point when we set
> hfile.block.cache.size to zero.
> It caused the BlockCacheTmplImpl.java:123 to throw null exception.
> {code}
> org.jamon.escaping.Escaping.HTML.write(org.jamon.emit.StandardEmitter.valueOf(StringUtils.humanReadableInt(cacheConfig.getBlockCache().size())),
> jamonWriter);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
