[
https://issues.apache.org/jira/browse/HBASE-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212007#comment-14212007
]
Qiang Tian commented on HBASE-12451:
------------------------------------
Shaohui boss, this looks not a small change? :-)
Even if average region count is used, below code will use max file size in
most cases - e.g. when tableRegionsCount = 4, the value is 16384M which is
bigger than DEFAULT_MAX_FILE_SIZE..
{code}
return tableRegionsCount == 0 || tableRegionsCount > 100 ?
getDesiredMaxFileSize():
Math.min(getDesiredMaxFileSize(),
this.initialSize * tableRegionsCount * tableRegionsCount *
tableRegionsCount);
{code}
Personally I like KISS - a simple configure parameter can resolve this case -
if we have many complains on existing region split policy, that is another
story...my 2 cents.
> IncreasingToUpperBoundRegionSplitPolicy may cause unnecessary region splits
> in rolling update of cluster
> --------------------------------------------------------------------------------------------------------
>
> Key: HBASE-12451
> URL: https://issues.apache.org/jira/browse/HBASE-12451
> Project: HBase
> Issue Type: Bug
> Reporter: Liu Shaohui
> Assignee: Liu Shaohui
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12451-v1.diff
>
>
> Currently IncreasingToUpperBoundRegionSplitPolicy is the default region split
> policy. In this policy, split size is the number of regions that are on this
> server that all are of the same table, cubed, times 2x the region flush size.
> But when unloading regions of a regionserver in a cluster using
> region_mover.rb, the number of regions that are on this server that all are
> of the same table will decrease, and the split size will decrease too, which
> may cause the left region split in the regionsever. Region Splits also
> happens when loading regions of a regionserver in a cluster.
> A improvment may set a minimum split size in
> IncreasingToUpperBoundRegionSplitPolicy
> Suggestions are welcomed. Thanks~
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
