[
https://issues.apache.org/jira/browse/HBASE-12480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215181#comment-14215181
]
Virag Kothari commented on HBASE-12480:
---------------------------------------
bq. If serverName is null, onlineServers should not contain it.
Problem is onlineServers cannot do that contain check. Passing null to
ConcurrentMap.keySet().contains() will throw NPE
bq. In master branch, the server should be never null if it is in these states.
TestAssignmentManagerOnCluster.testFailedOpen() asserts for null server in
failed open state. Could we have a possible case on real cluster where we try
to assign a region not in region states and end up in similar situation?
bq. Should use invokeUnAssign.
Hmm, will make the change. My initial thinking was that we need to make
blocking calls but that doesn't seem to matter.
> Regions in FAILED_OPEN/FAILED_CLOSE should be processed on master failover
> ---------------------------------------------------------------------------
>
> Key: HBASE-12480
> URL: https://issues.apache.org/jira/browse/HBASE-12480
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Reporter: Virag Kothari
> Assignee: Virag Kothari
> Fix For: 2.0.0, 0.98.9, 0.99.2
>
> Attachments: HBASE-12480.patch
>
>
> For zk assignment, we used to process this regions. For zk less assignment,
> we should do the same
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
