[ https://issues.apache.org/jira/browse/HBASE-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215573#comment-14215573 ]
Hadoop QA commented on HBASE-11099: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12682024/HBASE-11099.v1-2.0.patch against trunk revision . ATTACHMENT ID: 12682024 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11724//console This message is automatically generated. > Two situations where we could open a region with smaller sequence number > ------------------------------------------------------------------------ > > Key: HBASE-11099 > URL: https://issues.apache.org/jira/browse/HBASE-11099 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.99.1 > Reporter: Jeffrey Zhong > Assignee: Stephen Yuan Jiang > Fix For: 1.0.0, 2.0.0, 0.99.2 > > Attachments: HBASE-11099.v1-2.0.patch > > > Recently I happened to run into code where we potentially could open region > with smaller sequence number: > 1) Inside function: HRegion#internalFlushcache. This is due to we change the > way WAL Sync where we use late binding(assign sequence number right before > wal sync). > The flushSeqId may less than the change sequence number included in the flush > which may cause later region opening code to use a smaller than expected > sequence number when we reopen the region. > {code} > flushSeqId = this.sequenceId.incrementAndGet(); > ... > mvcc.waitForRead(w); > {code} > 2) HRegion#replayRecoveredEdits where we have following code: > {code} > ... > if (coprocessorHost != null) { > status.setStatus("Running pre-WAL-restore hook in coprocessors"); > if (coprocessorHost.preWALRestore(this.getRegionInfo(), key, > val)) { > // if bypass this log entry, ignore it ... > continue; > } > } > ... > currentEditSeqId = key.getLogSeqNum(); > {code} > If coprocessor skip some tail WALEdits, then the function will return smaller > currentEditSeqId. In the end, a region may also open with a smaller sequence > number. This may cause data loss because Master may record a larger flushed > sequence Id and some WALEdits maybe skipped during recovery if the region > fail again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)