[ 
https://issues.apache.org/jira/browse/HBASE-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222492#comment-14222492
 ] 

Hadoop QA commented on HBASE-12471:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12683231/12471.reapply.reapply.v5.txt
  against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7.
  ATTACHMENT ID: 12683231

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 54 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +         if 
(!region.getRegionInfo().getEncodedName().equals(toMove.getRegionInfo().getEncodedName())
+       
Assert.assertFalse(destServer.getRegionsInTransitionInRS().containsKey(encodedRegionNameBytes));
+       
Assert.assertFalse(curServer.getRegionsInTransitionInRS().containsKey(encodedRegionNameBytes));

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11805//console

This message is automatically generated.

> Task 4. replace internal ConnectionManager#{delete,get}Connection use with 
> #close, #createConnection (0.98, 0.99) under src/main/java
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12471
>                 URL: https://issues.apache.org/jira/browse/HBASE-12471
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: 
> 0001-HBASE-12471-Task-4.-replace-internal-ConnectionManag.patch, 12404v9.txt, 
> 124471v4.txt, 12471.reapply.reapply.v5.txt, 12471.reapply.txt, 
> 12471.reapply.v4.txt, 12471.reapplyv2.txt, 12471.reapplyv2.txt, 
> 12471.reapplyv3.txt, 12471v10.txt, 12471v10.txt, 12471v11.txt, 12471v2.txt, 
> 12471v3.txt, 12471v6.txt, 12471v7.txt, 12471v9.txt
>
>
> Let me do this. A bunch of this was done in HBASE-12404 Let me see if can 
> find more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to