[
https://issues.apache.org/jira/browse/HBASE-12128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223361#comment-14223361
]
Hadoop QA commented on HBASE-12128:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683210/HBASE-12128.v1-2.0.patch
against master branch at commit 0df5ed2ca6ce3758b4745f63400fd81d17107038.
ATTACHMENT ID: 12683210
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3807 checkstyle errors (more than the master's current 3806 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11815//console
This message is automatically generated.
> Cache configuration and RpcController selection for Table in Connection
> -----------------------------------------------------------------------
>
> Key: HBASE-12128
> URL: https://issues.apache.org/jira/browse/HBASE-12128
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Andrew Purtell
> Assignee: Stephen Yuan Jiang
> Fix For: 1.0.0, 2.0.0, 0.98.9, 0.99.2
>
> Attachments: HBASE-12128.v1-2.0.patch
>
> Original Estimate: 120h
> Time Spent: 72h
> Remaining Estimate: 48h
>
> Creating Table instances should be lightweight. Apps that manage their own
> Connections are expected to create Tables on demand for each interaction.
> However we look up values from Hadoop Configuration when constructing Table
> objects for storing to some of its fields. Configuration is a heavyweight
> registry that does a lot of string operations and regex matching. Method
> calls into Configuration account for 48.25% of CPU time when creating the
> HTable object in 0.98. Another ~48% of CPU is spent constructing the desired
> RpcController object via reflection in 0.98. Together this can account for
> ~20% of total on-CPU time of the client. See parent issue for more detail.
> We are using Connection like a factory for Table. We should cache
> configuration for Table in Connection. We should also create by reflection
> once and cache the desired RpcController object, and clone it for new Tables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
