[
https://issues.apache.org/jira/browse/HBASE-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228379#comment-14228379
]
Hadoop QA commented on HBASE-12598:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12684192/HBASE-12598.patch
against master branch at commit 0f8894cd6435ed6962ec3d7c81be4cb0d4f7657e.
ATTACHMENT ID: 12684192
{color:red}-1 @author{color}. The patch appears to contain 2 @author tags
which the Hadoop community has agreed to not allow in code contributions.
{color:green}+1 tests included{color}. The patch appears to include 2175
new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11859//console
This message is automatically generated.
> Replace uses of setAutoFlush(boolean, boolean) in 0.99.2
> --------------------------------------------------------
>
> Key: HBASE-12598
> URL: https://issues.apache.org/jira/browse/HBASE-12598
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.99.2
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Attachments: HBASE-12598.patch
>
>
> HBASE-12490 changed the 2.0.0 branch. This is a similar change to branch-1.
> The various uses of setAutoFlush() seem to need some tlc. There's a note in
> HTableInterface: "@deprecated in 0.99 since setting clearBufferOnFail is
> deprecated. Use setAutoFlushTo(boolean) instead." It would be ideal to change
> all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if
> possible.
> HTable.setAutoFlush(boolean, boolean) is used in a handful of places.
> setAutoFlush(false, false) has the same results as
> HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the
> same affect as Table.setAutoFlushTo(false), assuming
> HTable.setAutoFlush(false) was not called previously (by default, the second
> parameter, clearBufferOnFail, is true and should remain true according to the
> comments).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
