[
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229241#comment-14229241
]
Hadoop QA commented on HBASE-12603:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12684308/HBASE-12603.patch
against master branch at commit 5985b485943e4664b83fad2f2cfd089e6031b062.
ATTACHMENT ID: 12684308
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3558 checkstyle errors (more than the master's current 3535 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * <li>Classes that are {@link
org.apache.hadoop.hbase.classification.InterfaceAudience.LimitedPrivate}
+ * {@link #ReversedScannerCallable(ClusterConnection, TableName, Scan,
ScanMetrics, byte[], RpcControllerFactory )}
+ * This only works properly if the {@link
org.apache.hadoop.hbase.master.cleaner.TimeToLiveHFileCleaner}
+ * is also enabled (it always should be), since it may take a little time for
the ZK notification to
+ * Exception that a user defined constraint throws on failure of a {@link
org.apache.hadoop.hbase.client.Put}.
+ * Does <b>NOT</b> attempt the {@link org.apache.hadoop.hbase.client.Put}
multiple times, since the constraint
+ * <it>should</it> fail every time for the same {@link
org.apache.hadoop.hbase.client.Put} (it should be
+ * ZooKeeper based implementation of {@link
org.apache.hadoop.hbase.master.SplitLogManagerCoordination}
+ * {@link
org.apache.hadoop.hbase.master.SplitLogManagerCoordination#removeStaleRecoveringRegions(Set)}
+ * from this method. The custom scanner can then inspect {@link
org.apache.hadoop.hbase.KeyValue}s
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11874//console
This message is automatically generated.
> Remove javadoc warnings introduced due to removal of unused imports
> -------------------------------------------------------------------
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings
> were introduced because some of the classes referred to were no longer
> imported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
