[ 
https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230153#comment-14230153
 ] 

stack commented on HBASE-12559:
-------------------------------

Needs release note.

Why we add updateMasterConfiguration?  We have updateConfiguration already with 
ServerName... why not just pass Master SN? (Our Admin Interface is nice and 
clean... lets be careful adding to it)

Why we doing reload conf and set of conf into balancer when we have new 
ConfigurationObserver system just added?  Isn't this dangerous:

    conf.reloadConfiguration();

Its the general master's config that is being reloaded.  The 
ConfigurationObserver system was added because blanket changing of configs 
could have dangerous side effects.





> Provide LoadBalancer with online configuration capability
> ---------------------------------------------------------
>
>                 Key: HBASE-12559
>                 URL: https://issues.apache.org/jira/browse/HBASE-12559
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0
>
>         Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt, 12559-v4.txt, 
> 12559-v4.txt, 12559-v5.txt, 12559-v6.txt
>
>
> StochasticLoadBalancer has many knobs which user can adjust.
> It would increase productivity by allowing StochasticLoadBalancer to accept 
> online configuration changes.
> LoadBalancer already implements setConf(Configuration) method which reloads 
> relevant configuration parameters.
> We need to add updateMasterConfiguration() method to Admin which invokes the 
> setConf() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to