[ 
https://issues.apache.org/jira/browse/HBASE-12614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232185#comment-14232185
 ] 

Lars Hofhansl commented on HBASE-12614:
---------------------------------------

The shared readers are closed in HStore.completeCompaction(...). There we 
simply close the readers.

I think v1 is better. We told he compactor to use private readers, after the 
compaction finished we close the readers. If that fail I think we can simply 
proceed. (but as I said, I am not sure)


> Potentially unclosed StoreFile(s) in DefaultCompactor#compact()
> ---------------------------------------------------------------
>
>                 Key: HBASE-12614
>                 URL: https://issues.apache.org/jira/browse/HBASE-12614
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 12614-v1.txt, 12614-v2.txt
>
>
> Here is the related code (around line 129):
> {code}
>         for (StoreFile f : readersToClose) {
>           f.closeReader(true);
>         }
> {code}
> If any closeReader() call throws IOException, the remaining StoreFile(s) 
> would not be closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to