[
https://issues.apache.org/jira/browse/HBASE-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235337#comment-14235337
]
Hadoop QA commented on HBASE-12597:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685299/HBASE-12597-v5.patch
against master branch at commit 08754f2c431b829b0d6269bdb23284dd679ed8ca.
ATTACHMENT ID: 12685299
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 51 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail.
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java:[92,16]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java:[121,16]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java:[203,16]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java:[326,16]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java:[139,16]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java:[125,16]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java:[416,20]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java:[200,13]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java:[242,13]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java:[273,13]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java:[357,13]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java:[120,16]
cannot find symbol
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile
(default-testCompile) on project hbase-server: Compilation failure: Compilation
failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java:[92,16]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable rpcClient of type
org.apache.hadoop.hbase.ipc.RpcClient
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java:[121,16]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable rpcClient of type
org.apache.hadoop.hbase.ipc.RpcClient
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java:[203,16]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable rpcClient of type
org.apache.hadoop.hbase.ipc.RpcClient
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java:[326,16]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable rpcClient of type
org.apache.hadoop.hbase.ipc.RpcClient
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java:[139,16]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable rpcClient of type
org.apache.hadoop.hbase.ipc.RpcClient
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java:[125,16]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable rpcClient of type
org.apache.hadoop.hbase.client.TestClientTimeouts.RandomTimeoutRpcClient
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java:[416,20]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable rpcClient of type
org.apache.hadoop.hbase.ipc.RpcClient
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java:[200,13]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable client of type
org.apache.hadoop.hbase.ipc.RpcClientImpl
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java:[242,13]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable client of type
org.apache.hadoop.hbase.ipc.RpcClientImpl
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java:[273,13]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable client of type
org.apache.hadoop.hbase.ipc.RpcClientImpl
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java:[357,13]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable client of type
org.apache.hadoop.hbase.ipc.RpcClientImpl
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java:[120,16]
cannot find symbol
[ERROR] symbol: method stop()
[ERROR] location: variable rpcClient of type
org.apache.hadoop.hbase.ipc.RpcClient
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :hbase-server
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11949//console
This message is automatically generated.
> Add RpcClient interface and enable changing of RpcClient implementation
> -----------------------------------------------------------------------
>
> Key: HBASE-12597
> URL: https://issues.apache.org/jira/browse/HBASE-12597
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Reporter: Jurriaan Mous
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12597-v1.patch, HBASE-12597-v2.patch,
> HBASE-12597-v3.patch, HBASE-12597-v4.patch, HBASE-12597-v4.patch,
> HBASE-12597-v5.patch, HBASE-12597.patch
>
>
> Currently HConnectionImplementation works with the included RpcClient which
> is a direct implementation and not defined by an interface.
> It would be great to be able to swap out the default RpcClient with another
> implementation which can also be controlled by the default
> HConnectionImplementation.
> Suggested changes:
> - Create a RpcClient interface which defines all the ways
> HConnectionImplementation interacts with an RPC client. Like getting a
> blocking protobuf service interface or closing the client.
> - Define which RpcClient implementation to construct by setting a
> configuration variable which defaults to the current RpcClient.
> - Possibly create an abstract RpcClient class to only load all the basic Rpc
> layer configurations to be used in an implementation.
> Why? It enables experimentation with RpcClients which could enable new
> features or could be more performant than the included client.
> I created a new RpcClient implementation based on Netty which can also be
> called asynchronously. It would be great to also be able to use this
> RpcClient in all the default ways and tests to see if there are any issues
> with it.
> https://github.com/jurmous/async-hbase-client/
> https://github.com/jurmous/async-hbase-client/blob/master/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcClient.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
