[ 
https://issues.apache.org/jira/browse/HBASE-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jerry He updated HBASE-12682:
-----------------------------
    Description: 
While doing some compaction tuning and looking up some of the parameters, I 
noticed that hbase.regionserver.thread.compaction.throttle default value in the 
documentation and in hbase-site.xml seems to be off the mark.

{code}
  <property>
    <name>hbase.regionserver.thread.compaction.throttle</name>
    <value>2560</value>
    <description>There are two different thread pools for compactions, one for 
large compactions and
      the other for small compactions. This helps to keep compaction of lean 
tables (such as
        <systemitem>hbase:meta</systemitem>) fast. If a compaction is larger 
than this threshold, it
      goes into the large compaction pool. In most cases, the default value is 
appropriate. Default:
      2 x hbase.hstore.compaction.max x hbase.hregion.memstore.flush.size 
(which defaults to 128).
      The value field assumes that the value of 
hbase.hregion.memstore.flush.size is unchanged from
      the default.</description>
  </property>
{code}

It should be in bytes. Or am I missing anything?
It is not a problem in 0.98 since the property is not in hbase-site.xml over 
there. It is obtained dynamically:
{code}
throttlePoint =  conf.getLong("hbase.regionserver.thread.compaction.throttle",
          2 * maxFilesToCompact * storeConfigInfo.getMemstoreFlushSize());
{code}


  was:
While doing some compaction tuning and looking up some of the parameters, I 
noticed that hbase.regionserver.thread.compaction.throttle default value in the 
documentation and in hbase-site.xml seems to be off the mark.

{code}
  <property>
    <name>hbase.regionserver.thread.compaction.throttle</name>
    <value>2560</value>
    <description>There are two different thread pools for compactions, one for 
large compactions and
      the other for small compactions. This helps to keep compaction of lean 
tables (such as
        <systemitem>hbase:meta</systemitem>) fast. If a compaction is larger 
than this threshold, it
      goes into the large compaction pool. In most cases, the default value is 
appropriate. Default:
      2 x hbase.hstore.compaction.max x hbase.hregion.memstore.flush.size 
(which defaults to 128).
      The value field assumes that the value of 
hbase.hregion.memstore.flush.size is unchanged from
      the default.</description>
  </property>
{code}

It should be in bytes. Or am I missing anyting?
It is not a problem in 0.98 since the property is not in hbase-site.xml over 
there. It is obtained dynamically:
{code}
throttlePoint =  conf.getLong("hbase.regionserver.thread.compaction.throttle",
          2 * maxFilesToCompact * storeConfigInfo.getMemstoreFlushSize());
{code}



> compaction thread throttle value is not correct in hbase-default.xml
> --------------------------------------------------------------------
>
>                 Key: HBASE-12682
>                 URL: https://issues.apache.org/jira/browse/HBASE-12682
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 2.0.0
>
>
> While doing some compaction tuning and looking up some of the parameters, I 
> noticed that hbase.regionserver.thread.compaction.throttle default value in 
> the documentation and in hbase-site.xml seems to be off the mark.
> {code}
>   <property>
>     <name>hbase.regionserver.thread.compaction.throttle</name>
>     <value>2560</value>
>     <description>There are two different thread pools for compactions, one 
> for large compactions and
>       the other for small compactions. This helps to keep compaction of lean 
> tables (such as
>         <systemitem>hbase:meta</systemitem>) fast. If a compaction is larger 
> than this threshold, it
>       goes into the large compaction pool. In most cases, the default value 
> is appropriate. Default:
>       2 x hbase.hstore.compaction.max x hbase.hregion.memstore.flush.size 
> (which defaults to 128).
>       The value field assumes that the value of 
> hbase.hregion.memstore.flush.size is unchanged from
>       the default.</description>
>   </property>
> {code}
> It should be in bytes. Or am I missing anything?
> It is not a problem in 0.98 since the property is not in hbase-site.xml over 
> there. It is obtained dynamically:
> {code}
> throttlePoint =  conf.getLong("hbase.regionserver.thread.compaction.throttle",
>           2 * maxFilesToCompact * storeConfigInfo.getMemstoreFlushSize());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to