[ https://issues.apache.org/jira/browse/HBASE-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247988#comment-14247988 ]
Hadoop QA commented on HBASE-12699: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687442/HBASE-12699.v1.master.patch against master branch at commit 96c6b9815ddbc9f2589655df4ad2381af04ac9f8. ATTACHMENT ID: 12687442 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + # DEFERRED_LOG_FLUSH is deprecated and was replaced by DURABILITY. To keep backward compatible, it still exists. + # However, it has to set before DURABILITY so that DURABILITY could overwrite if both args are set + # DEFERRED_LOG_FLUSH is deprecated and was replaced by DURABILITY. To keep backward compatible, it still exists. + # However, it has to set before DURABILITY so that DURABILITY could overwrite if both args are set {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . {color:red}-1 core zombie tests{color}. There are 2 zombie test(s): at org.apache.mahout.clustering.fuzzykmeans.TestFuzzyKmeansClustering.testFuzzyKMeansMRJob(TestFuzzyKmeansClustering.java:195) at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1558) at com.carrotsearch.randomizedtesting.RandomizedRunner.access$600(RandomizedRunner.java:79) at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:736) at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:772) at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:786) at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358) at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:782) at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:442) at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:745) at com.carrotsearch.randomizedtesting.RandomizedRunner$3.evaluate(RandomizedRunner.java:647) at com.carrotsearch.randomizedtesting.RandomizedRunner$4.evaluate(RandomizedRunner.java:681) at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:692) at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358) at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:787) at com.carrotsearch.randomizedtesting.ThreadLeakControl$2.evaluate(ThreadLeakControl.java:385) at com.carrotsearch.randomizedtesting.RandomizedRunner.runSuite(RandomizedRunner.java:555) at com.carrotsearch.randomizedtesting.RandomizedRunner.access$200(RandomizedRunner.java:79) at com.carrotsearch.randomizedtesting.RandomizedRunner$1.run(RandomizedRunner.java:491) at com.carrotsearch.randomizedtesting.RandomizedRunner.runSuite(RandomizedRunner.java:501) at com.carrotsearch.randomizedtesting.RandomizedRunner.run(RandomizedRunner.java:399) at org.apache.mahout.clustering.streaming.cluster.BallKMeansTest.testClusteringMultipleRuns(BallKMeansTest.java:79) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12094//console This message is automatically generated. > undefined method `setAsyncLogFlush' exception throw when setting > DEFERRED_LOG_FLUSH=>true > ----------------------------------------------------------------------------------------- > > Key: HBASE-12699 > URL: https://issues.apache.org/jira/browse/HBASE-12699 > Project: HBase > Issue Type: Bug > Components: shell > Affects Versions: 2.0.0, 0.99.2 > Reporter: Stephen Yuan Jiang > Assignee: Stephen Yuan Jiang > Attachments: HBASE-12699.v1.master.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > In hbase shell, when trying to set DEFERRED_LOG_FLUSH during create or alter, > an undefined method `setAsyncLogFlush' exception was thrown. > This is due to that DEFERRED_LOG_FLUSH was deprecated and the > setAsyncLogFlush method was removed. It was replaced by DURABILITY. > DEFERRED_LOG_FLUSH=>true is the same as DURABILITY=>'ASYNC_WAL' > The default is DURABILITY=>'SYNC_WAL', which is the same as the default > DEFERRED_LOG_FLUSH=>false > We should ask user to use the DURABILITY setting. In the meantime, for > backward compatibility, the hbase shell should still allow setting > DEFERRED_LOG_FLUSH. Internally, instead of calling setAsyncLogFlush, it > should call setDurability -- This message was sent by Atlassian JIRA (v6.3.4#6332)