[ https://issues.apache.org/jira/browse/HBASE-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251919#comment-14251919 ]
Ted Yu commented on HBASE-12712: -------------------------------- In master branch, we have: {code} if (!(forceMajor && isAllFiles)) { candidateSelection = skipLargeFiles(candidateSelection); isAllFiles = candidateFiles.size() == candidateSelection.size(); } {code} In 0.98, we have: {code} if (!forceMajor) { candidateSelection = skipLargeFiles(candidateSelection); } {code} Can you try 0.98.8 to see if the problem is still there ? > skipLargeFiles in minor compact but not in major compact > -------------------------------------------------------- > > Key: HBASE-12712 > URL: https://issues.apache.org/jira/browse/HBASE-12712 > Project: HBase > Issue Type: New Feature > Components: Compaction > Affects Versions: 0.98.6 > Reporter: Liu Junhong > Labels: newbie, patch > Fix For: 0.98.6 > > Attachments: compact.diff > > Original Estimate: 72h > Remaining Estimate: 72h > > Here is my case. After repeatedly minor compaction, the size of storefile is > very large. Compaction with large storefile will waste much bandwidth, so i > use the “hbase.hstore.compaction.max.size” to skip this case. But after use > this config, i find that major compaction will be skipped forever when i read > the source code and the deletes and muti-versions data my waste storage. So i > had to modify the code. > Now i'm try to submit my patch.But my patch is not perfect. I think there > should be an other config to determine if the large size storefile should > join major compaction in HColumnDescriptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)