[ 
https://issues.apache.org/jira/browse/HBASE-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254550#comment-14254550
 ] 

Sean Busbey commented on HBASE-12566:
-------------------------------------

{quote}
We have a meetup at AppDynamics upcoming on January 15: 
http://www.meetup.com/hbaseusergroup/events/218744798/ . How about finding an 
afternoon around that time to chew on this issue for a few hours, same day or 
before or after? At Salesforce HQ?
{quote}

Provided we coordinate with an email to both dev@ lists, that sounds good. Is 
this open to just PMCs, just committers, or the general community? I ask 
because I'm already scheduled in the bay area that week.

> HRegion should have an InterfaceAudience of LimitedPrivate(PHOENIX)
> -------------------------------------------------------------------
>
>                 Key: HBASE-12566
>                 URL: https://issues.apache.org/jira/browse/HBASE-12566
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>              Labels: Phoenix
>
> I've discovered after HBASE-12550 that Phoenix has a class that was broken by 
> a change to a package scoped method in HRegion:
> {code}
> diff --git 
> a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
>  b/hbase-server/src/main/java/org/apache/hadoop/hbase/reg
> index 39a9fdc..3377e6b 100644
> --- 
> a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> +++ 
> b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> @@ -4628,11 +4628,12 @@ public class HRegion implements HeapSize { // , 
> Writable{
>    /**
>     * Create a daughter region from given a temp directory with the region 
> data.
>     * @param hri Spec. for daughter region to open.
> +   * @param expectedReferenceFileCount
>     * @throws IOException
>     */
> -  HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws 
> IOException {
> +  HRegion createDaughterRegionFromSplits(final HRegionInfo hri, int 
> expectedReferenceFileCount) throws IOException {
>      // Move the files from the temporary .splits to the final /table/region 
> directory
> -    fs.commitDaughterRegion(hri);
> +    fs.commitDaughterRegion(hri, expectedReferenceFileCount);
> {code}
> We should change the HRegion InterfaceAudience to LimitedPrivate(COPROC, 
> PHOENIX).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to