[ https://issues.apache.org/jira/browse/HBASE-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261178#comment-14261178 ]
Hadoop QA commented on HBASE-12684: ----------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12689500/HBASE-12684-DEBUG3.patch against master branch at commit 0513a21dc8b86f57b5a6c1b742904821632f77f7. ATTACHMENT ID: 12689500 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12259//console This message is automatically generated. > Add new AsyncRpcClient > ---------------------- > > Key: HBASE-12684 > URL: https://issues.apache.org/jira/browse/HBASE-12684 > Project: HBase > Issue Type: Improvement > Components: Client > Reporter: Jurriaan Mous > Assignee: Jurriaan Mous > Attachments: HBASE-12684-DEBUG2.patch, HBASE-12684-DEBUG3.patch, > HBASE-12684-v1.patch, HBASE-12684-v10.patch, HBASE-12684-v11.patch, > HBASE-12684-v12.patch, HBASE-12684-v13.patch, HBASE-12684-v14.patch, > HBASE-12684-v15.patch, HBASE-12684-v16.patch, HBASE-12684-v17.patch, > HBASE-12684-v2.patch, HBASE-12684-v3.patch, HBASE-12684-v4.patch, > HBASE-12684-v5.patch, HBASE-12684-v6.patch, HBASE-12684-v7.patch, > HBASE-12684-v8.patch, HBASE-12684-v9.patch, HBASE-12684.patch > > > With the changes in HBASE-12597 it is possible to add new RpcClients. This > issue is about adding a new Async RpcClient which would enable HBase to do > non blocking protobuf service communication. > Besides delivering a new AsyncRpcClient I would also like to ask the question > what it would take to replace the current RpcClient? This would enable to > simplify async code in some next issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)