[ 
https://issues.apache.org/jira/browse/HBASE-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274033#comment-14274033
 ] 

Enis Soztutar commented on HBASE-12808:
---------------------------------------

This is good. This can be used instead of HBASE-12556. However there were some 
discussion for whether we should have a unit test or a per-RC script for this. 
I am still very much in favor of a unit test to distribute the burden 
(maintaining  source and binary compat) to patch authors and reviewers rather 
than leave everything for the RM. I'll keep HBASE-12556 open to pursue that. 

Annotation support in the tool is great. We also annotate individual methods 
within InterfaceAudience.Public classes. Does the tool support an exclude list 
as well for annotations? 




> Use Java API Compliance Checker for binary/source compatibility
> ---------------------------------------------------------------
>
>                 Key: HBASE-12808
>                 URL: https://issues.apache.org/jira/browse/HBASE-12808
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Dima Spivak
>            Assignee: Dima Spivak
>         Attachments: HBASE-12808_v1.patch, HBASE-12808_v2.patch, 
> HBASE-12808_v3.patch
>
>
> Following [~busbey]'s suggestion in HBASE-12556, I've spent some time playing 
> with the [Java API Compliance 
> Checker|http://ispras.linuxbase.org/index.php/Java_API_Compliance_Checker] 
> and think it would be a great addition to /dev-support. I propose that we use 
> it to replace the JDiff wrappers we currently have there (since it does what 
> JDiff does and more), and look into putting up automation at 
> builds.apache.org to run the tool regularly (e.g. latest release of a 
> particular branch vs. latest commit of that same branch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to