[ 
https://issues.apache.org/jira/browse/HBASE-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276672#comment-14276672
 ] 

Hadoop QA commented on HBASE-12393:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12692173/HBASE-12393-master.patch
  against master branch at commit 1a21c1684c5d68cb2d1da8ed33500993b0965f8a.
  ATTACHMENT ID: 12692173

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release 
audit warnings (more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/patchReleaseAuditWarnings.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12459//console

This message is automatically generated.

> The regionserver web will throw exception if we disable block cache
> -------------------------------------------------------------------
>
>                 Key: HBASE-12393
>                 URL: https://issues.apache.org/jira/browse/HBASE-12393
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver, UI
>    Affects Versions: 0.98.7
>         Environment: ubuntu 12.04 64bits, hadoop-2.2.0, hbase-0.98.7-hadoop2
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0
>
>         Attachments: HBASE-12393.patch
>
>
> The CacheConfig.getBlockCache() will return the null point when we set 
> hfile.block.cache.size to zero.
> The BlockCacheTmpl.jamon doesn't make a check on null blockcache.
> {code}
> <%if cacheConfig == null %>
> <p>CacheConfig is null</p>
> <%else>
> <table class="table table-striped">
>     <tr>
>         <th>Attribute</th>
>         <th>Value</th>
>         <th>Description</th>
>     </tr>
>     <tr>
>         <td>Size</td>
>         <td><% 
> StringUtils.humanReadableInt(cacheConfig.getBlockCache().size()) %></td>
>         <td>Total size of Block Cache (bytes)</td>
>     </tr>
>     <tr>
>         <td>Free</td>
>         <td><% 
> StringUtils.humanReadableInt(cacheConfig.getBlockCache().getFreeSize()) 
> %></td>
>         <td>Free space in Block Cache (bytes)</td>
>     </tr>
>     <tr>
>         <td>Count</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getBlockCount()) %></td>
>         <td>Number of blocks in Block Cache</td>
>     </tr>
>     <tr>
>         <td>Evicted</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td>
>         <td>Number of blocks evicted</td>
>     </tr>
>     <tr>
>         <td>Evictions</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td>
>         <td>Number of times an eviction occurred</td>
>     </tr>
>     <tr>
>         <td>Hits</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getHitCount()) %></td>
>         <td>Number requests that were cache hits</td>
>     </tr>
>     <tr>
>         <td>Hits Caching</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td>
>         <td>Cache hit block requests but only requests set to use Block 
> Cache</td>
>     </tr>
>     <tr>
>         <td>Misses</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getMissCount()) %></td>
>         <td>Number of requests that were cache misses</td>
>     </tr>
>     <tr>
>         <td>Misses Caching</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getMissCount()) %></td>
>         <td>Block requests that were cache misses but only requests set to 
> use Block Cache</td>
>     </tr>
>     <tr>
>         <td>Hit Ratio</td>
>         <td><% String.format("%,.2f", 
> cacheConfig.getBlockCache().getStats().getHitRatio() * 100) %><% "%" %></td>
>         <td>Hit Count divided by total requests count</td>
>     </tr>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to