[
https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278042#comment-14278042
]
Sean Busbey commented on HBASE-11677:
-------------------------------------
I can empathize with needing logs for flakey failures.
Would it be a problem to enable those via log4j so that we don't need
programmatic tuning? We could leave a comment that the verbosity is for
particular tests, similar to how we call out when they might be needed
currently.
It would mean more logs when running some subsets of tests, but the current
code in master is turning those on for all following tests once one of the test
cases runs. (I think @stack and [~dimaspivak] recently fixed problems with too
much logging, maybe they have an idea)
> Make Logger instance modifiers consistent
> -----------------------------------------
>
> Key: HBASE-11677
> URL: https://issues.apache.org/jira/browse/HBASE-11677
> Project: HBase
> Issue Type: Task
> Reporter: Sean Busbey
> Priority: Minor
> Labels: beginner, sonar
> Attachments: HBASE-11677-v1.patch, HBASE-11677-v2.patch,
> HBASE-11677-v3.patch, HBASE-11677.patch
>
>
> We have some instances of Logger that are missing one of being private,
> static, and final.
> ex from HealthChecker.java, missing final
> {code}
> private static Log LOG = LogFactory.getLog(HealthChecker.class);
> {code}
> * Clean up where possible by making {{private static final}}
> * If we can't, add a non-javadoc note about why
> One way to look for problematic instances is to grep for initial assignment
> for the commonly used LOG member, e.g.
> * missing final: {{grep -r "LOG =" * | grep -v "final"}}
> * missing static: {{grep -r "LOG =" * | grep -v "static"}}
> * missing private: {{grep -r "LOG =" * | grep -v "private"}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
