[ https://issues.apache.org/jira/browse/HBASE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107923#comment-13107923 ]
jirapos...@reviews.apache.org commented on HBASE-4415: ------------------------------------------------------ bq. On 2011-09-18 04:41:44, Lars Hofhansl wrote: bq. > Generally it might be good to be able to define prefixes similar to what autoconf scripts do. Such as: bq. > --prefix=DIR [PREFIX/etc] bq. > --sysconfdir=DIR [PREFIX/etc] bq. > bq. > And so on. bq. > bq. > The hbase-site.xml and hbase-env.sh templates now have to be maintained separately, hence this makes config changes harder to maintain. bq. > bq. > In general this seems to be mostly useful for beginners of HBase, right? bq. > (Oldtimers will have a mechanism in place to setup HBase - puppet, chef, fabric, etc. bq. > bq. > So I wonder if a more useful avenue would be to post this as part of the HBase book or some other getting started spot on the HBase site. bq. > Hadoop related software used to deploy in isolated directory and use environment variables to drive the location of the software. GNU layout of single prefix does not work for tarball deployment because there are prefix directory per service. This is the reason that --hadoop-home, --hbase-home are implemented instead of --prefix. This is both useful for beginner or for script automation. I will include some documents for HBase book or HBase site. bq. On 2011-09-18 04:41:44, Lars Hofhansl wrote: bq. > /src/packages/hbase-setup-conf.sh, line 177 bq. > <https://reviews.apache.org/r/1925/diff/1/?file=41428#file41428line177> bq. > bq. > Isn't /usr a strange default for a Hadoop (or HBase or ZooKeeper) installation? bq. > Maybe the script should rather check for a value, and fail if none was given. Existing tarball deployment does not have a default location, hence, the default is set to /usr for rpm/debian package default location. I will added a check for /usr/bin/hadoop and bail out if hadoop does not exist. bq. On 2011-09-18 04:41:44, Lars Hofhansl wrote: bq. > /src/packages/hbase-setup-conf.sh, line 245 bq. > <https://reviews.apache.org/r/1925/diff/1/?file=41428#file41428line245> bq. > bq. > I don't see HBASE_LOG_DIR defaulted anywhere. bq. > Same for HBASE_PID_DIR. Good catch, I will make defaults for those two properties. How about default HBASE_LOG_DIR to ${HBASE_HOME}/var/log and ${HBASE_HOME}/var/run for consistency? bq. On 2011-09-18 04:41:44, Lars Hofhansl wrote: bq. > /src/packages/templates/conf/hbase-env.sh, line 3 bq. > <https://reviews.apache.org/r/1925/diff/1/?file=41429#file41429line3> bq. > bq. > Wow 2007... that's old :) bq. > I think the latest convention is not to include he year. I will make the change to exclude the year. Thanks :) - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1925/#review1957 ----------------------------------------------------------- On 2011-09-16 00:06:21, Eric Yang wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1925/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-09-16 00:06:21) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. Create a post installation script to streamline configuration tasks for HBase. bq. bq. usage: /usr/sbin/hbase-setup-conf.sh <parameters> bq. bq. Optional parameters: bq. --hadoop-conf=/etc/hadoop Set Hadoop configuration directory location bq. --hadoop-home=/usr Set Hadoop directory location bq. --hadoop-namenode=localhost Set Hadoop namenode hostname bq. --hadoop-replication=3 Set HDFS replication bq. --hbase-home=/usr Set HBase directory location bq. --hbase-conf=/etc/hbase Set HBase configuration directory location bq. --hbase-log=/var/log/hbase Set HBase log directory location bq. --hbase-pid=/var/run/hbase Set HBase pid directory location bq. --hbase-user=hbase Set HBase user bq. --java-home=/usr/java/default Set JAVA_HOME directory location bq. --kerberos-realm=KERBEROS.EXAMPLE.COM Set Kerberos realm bq. --kerberos-principal-id=_HOST Set Kerberos principal ID bq. --keytab-dir=/etc/security/keytabs Set keytab directory bq. --regionservers=localhost Set regionservers hostnames bq. --zookeeper-home=/usr Set ZooKeeper directory location bq. --zookeeper-quorum=localhost Set ZooKeeper Quorum bq. --zookeeper-snapshot=/var/lib/zookeeper Set ZooKeeper snapshot location bq. bq. bq. This addresses bug HBASE-4415. bq. https://issues.apache.org/jira/browse/HBASE-4415 bq. bq. bq. Diffs bq. ----- bq. bq. /src/assembly/all.xml 1170899 bq. /src/packages/hbase-setup-conf.sh PRE-CREATION bq. /src/packages/templates/conf/hbase-env.sh PRE-CREATION bq. /src/packages/templates/conf/hbase-site.xml PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/1925/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Eric bq. bq. > Add configuration script for setup HBase (hbase-setup-conf.sh) > -------------------------------------------------------------- > > Key: HBASE-4415 > URL: https://issues.apache.org/jira/browse/HBASE-4415 > Project: HBase > Issue Type: New Feature > Components: scripts > Environment: Java 6, Linux > Reporter: Eric Yang > Assignee: Eric Yang > Attachments: HBASE-4415-1.patch, HBASE-4415.patch > > > The goal of this jura is to provide a installation script for configuring > HBase environment and configuration. By using the same pattern of > *-setup-conf.sh for all Hadoop related projects. For HBase, the usage of the > script looks like this: > {noformat} > usage: ./hbase-setup-conf.sh <parameters> > Optional parameters: > --hadoop-conf=/etc/hadoop Set Hadoop configuration directory > location > --hadoop-home=/usr Set Hadoop directory location > --hadoop-namenode=localhost Set Hadoop namenode hostname > --hadoop-replication=3 Set HDFS replication > --hbase-home=/usr Set HBase directory location > --hbase-conf=/etc/hbase Set HBase configuration > directory location > --hbase-log=/var/log/hbase Set HBase log directory location > --hbase-pid=/var/run/hbase Set HBase pid directory location > --hbase-user=hbase Set HBase user > --java-home=/usr/java/default Set JAVA_HOME directory location > --kerberos-realm=KERBEROS.EXAMPLE.COM Set Kerberos realm > --kerberos-principal-id=_HOST Set Kerberos principal ID > --keytab-dir=/etc/security/keytabs Set keytab directory > --regionservers=localhost Set regionservers hostnames > --zookeeper-home=/usr Set ZooKeeper directory location > --zookeeper-quorum=localhost Set ZooKeeper Quorum > --zookeeper-snapshot=/var/lib/zookeeper Set ZooKeeper snapshot location > {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira