[ https://issues.apache.org/jira/browse/HBASE-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109810#comment-13109810 ]
jirapos...@reviews.apache.org commented on HBASE-4014: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/969/#review2007 ----------------------------------------------------------- Ship it! Looks good to me, assuming the added tests all pass. There are some tweaks we could make to the tests, but I could do that on commit, if that's okay with you. src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterCoprocessorExceptionWithRemove.java <https://reviews.apache.org/r/969/#comment4526> I would use BuggyMasterObserver.class.getName(). It'll survive any class renames without having the manually edit the string here. src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterCoprocessorExceptionWithRemove.java <https://reviews.apache.org/r/969/#comment4525> can just use fail() here src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithAbort.java <https://reviews.apache.org/r/969/#comment4527> Might be easier to just check HRegionServer.isAborted() on the RS hosting the table region, now that we have that? src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithRemove.java <https://reviews.apache.org/r/969/#comment4528> Could probably also just check HRegionServer.isAborted() here instead of doing the ZK watching? - Gary On 2011-09-20 23:33:04, Eugene Koontz wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/969/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-09-20 23:33:04) bq. bq. bq. Review request for hbase, Gary Helmling and Mingjie Lai. bq. bq. bq. Summary bq. ------- bq. bq. https://issues.apache.org/jira/browse/HBASE-4014 Coprocessors: Flag the presence of coprocessors in logged exceptions bq. bq. The general gist here is to wrap each of {Master,RegionServer}CoprocessorHost's coprocessor call inside a bq. bq. "try { ... } catch (Throwable e) { handleCoprocessorThrowable(e) }" bq. bq. block. bq. bq. handleCoprocessorThrowable() is responsible for either passing 'e' along to the client (if 'e' is an IOException) or, otherwise, aborting the service (Regionserver or Master). bq. bq. The abort message contains a list of the loaded coprocessors for crash analysis. bq. bq. bq. This addresses bug HBASE-4014. bq. https://issues.apache.org/jira/browse/HBASE-4014 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 4e492e1 bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 06bf814 bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 0c95017 bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java bff1f6c bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a6cf6a8 bq. src/main/resources/hbase-default.xml 2c8f44b bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterCoprocessorExceptionWithAbort.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterCoprocessorExceptionWithRemove.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithAbort.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithRemove.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/969/diff bq. bq. bq. Testing bq. ------- bq. bq. patch includes two tests: bq. bq. TestMasterCoprocessorException.java bq. TestRegionServerCoprocessorException.java bq. bq. both tests pass in my build environment. bq. bq. bq. Thanks, bq. bq. Eugene bq. bq. > Coprocessors: Flag the presence of coprocessors in logged exceptions > -------------------------------------------------------------------- > > Key: HBASE-4014 > URL: https://issues.apache.org/jira/browse/HBASE-4014 > Project: HBase > Issue Type: Improvement > Components: coprocessors > Reporter: Andrew Purtell > Assignee: Eugene Koontz > Fix For: 0.92.0 > > Attachments: HBASE-4014.patch, HBASE-4014.patch, HBASE-4014.patch, > HBASE-4014.patch, HBASE-4014.patch > > > For some initial triage of bug reports for core versus for deployments with > loaded coprocessors, we need something like the Linux kernel's taint flag, > and list of linked in modules that show up in the output of every OOPS, to > appear above or below exceptions that appear in the logs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira