[ https://issues.apache.org/jira/browse/HBASE-12867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302664#comment-14302664 ]
Hadoop QA commented on HBASE-12867: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696053/HBASE-12867-v3.patch against master branch at commit fef78acf6534f6736c10d2054cf8cb479edd3291. ATTACHMENT ID: 12696053 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 2 zombie test(s): at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:162) at org.apache.hadoop.hdfs.TestDistributedFileSystem.testGetFileBlockStorageLocationsError(TestDistributedFileSystem.java:852) at org.apache.hadoop.hbase.TestAcidGuarantees.testScanAtomicity(TestAcidGuarantees.java:354) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12671//console This message is automatically generated. > Shell does not support custom replication endpoint specification > ---------------------------------------------------------------- > > Key: HBASE-12867 > URL: https://issues.apache.org/jira/browse/HBASE-12867 > Project: HBase > Issue Type: Bug > Reporter: Andrew Purtell > Assignee: Kevin Risden > Labels: beginner, beginners > Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 > > Attachments: HBASE-12867-v1.patch, HBASE-12867-v2.patch, > HBASE-12867-v3.patch, HBASE-12867-v3.patch, HBASE-12867-v3.patch, > HBASE-12867.patch > > > On HBASE-12254 and also at > https://github.com/risdenk/hbase-custom-replication-endpoint-example > [~risdenk] made the following observations and suggestions regarding custom > replication endpoints that I think are a reasonable blueprint for improvement: > {quote} > I was trying out the pluggable replication endpoint feature and found the > following: > - you must use the ReplicationAdmin to add the new ReplicationEndpoint > - hbase shell add_peer command doesn't support specifying a custom class > - hbase shell add_peer relies on the newly deprecated ReplicationAdmin > addPeer methods > - ReplicationAdmin addPeer tableCfs is now a Map<TableName, ? extends > Collection<String>> instead of a string > {quote} > We should fix the add_peer command in the shell at least. -- This message was sent by Atlassian JIRA (v6.3.4#6332)