[ 
https://issues.apache.org/jira/browse/HBASE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109824#comment-13109824
 ] 

Roman Shaposhnik commented on HBASE-4209:
-----------------------------------------

I was asked yesterday how this can be tested. I'm not quite sure I can come up 
with a traditional unit test for this change, but here's how to verify it 
manually:
{noformat}
$ bin/hbase master start & PID=$! ; sleep 15 ; kill $PID
{noformat}

And look for LOG messages of the following nature:

{noformat}
INFO regionserver.ShutdownHook: Shutdown hook starting; 
hbase.shutdown.hook=true; fsShutdownHook=Thread[Thread-18,5,main]
..............
INFO regionserver.ShutdownHook: Starting fs shutdown hook thread.
INFO regionserver.ShutdownHook: Shutdown hook finished.
{noformat}

Without the patch -- the HBase master simply dies (as in -- no messages get 
produced)

> The HBase hbase-daemon.sh SIGKILLs master when stopping it
> ----------------------------------------------------------
>
>                 Key: HBASE-4209
>                 URL: https://issues.apache.org/jira/browse/HBASE-4209
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: HBASE-4209.patch.txt
>
>
> There's a bit of code in hbase-daemon.sh that makes HBase master being 
> SIGKILLed when stopping it rather than trying SIGTERM (like it does for other 
> daemons). When HBase is executed in a standalone mode (and the only daemon 
> you need to run is master) that causes newly created tables to go missing as 
> unflushed data is thrown out. If there was not a good reason to kill master 
> with SIGKILL perhaps we can take that special case out and rely on SIGTERM.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to