[ 
https://issues.apache.org/jira/browse/HBASE-12956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308711#comment-14308711
 ] 

Enis Soztutar commented on HBASE-12956:
---------------------------------------

I was thinking that we do not need both bindAddress, and isa in RpcServer. 
The following line is equal to just using bindAddress:
{code}
isa.equals(bindAddress) ? isa : bindAddress
{code}

What I had in mind is you exact same patch, but without the RpcServer changes, 
and instead of 
{code}
     rpcServer = new RpcServer(rs, name, getServices(),
-      initialIsa, // BindAddress is IP we got for this server.
+      initialIsa,
+      bindAddress, // BindAddress is IP we got for this server.
{code}
just 
{code}
     rpcServer = new RpcServer(rs, name, getServices(),
-      initialIsa, // BindAddress is IP we got for this server.
+      bindAddress, // BindAddress is IP we got for this server.
{code}
let me know if this makes sense. 


> Binding to 0.0.0.0 is broken after HBASE-10569
> ----------------------------------------------
>
>                 Key: HBASE-12956
>                 URL: https://issues.apache.org/jira/browse/HBASE-12956
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>            Priority: Blocker
>             Fix For: 1.0.0, 2.0.0, 1.1.0
>
>         Attachments: 
> 0001-HBASE-12956-Binding-to-0.0.0.0-is-broken-after-HBASE.patch, 
> HBASE-12956-v2.txt
>
>
> After the Region Server and Master code was merged, we lost the functionality 
> to bind to 0.0.0.0 via hbase.regionserver.ipc.address and znodes now get 
> created with the wildcard address which means that RSs and the master cannot 
> connect to each other. Thanks to [~dimaspivak] for reporting the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to