[
https://issues.apache.org/jira/browse/HBASE-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310171#comment-14310171
]
Hudson commented on HBASE-12979:
--------------------------------
FAILURE: Integrated in HBase-TRUNK #6099 (See
[https://builds.apache.org/job/HBase-TRUNK/6099/])
HBASE-12979 Use setters instead of return values for handing back statistics
from HRegion methods (jyates: rev 75148385ee5b2065992aea19a810436196576f20)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Use setters instead of return values for handing back statistics from HRegion
> methods
> -------------------------------------------------------------------------------------
>
> Key: HBASE-12979
> URL: https://issues.apache.org/jira/browse/HBASE-12979
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.98.10
> Reporter: Andrew Purtell
> Assignee: Jesse Yates
> Labels: phoenix
> Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.10.1
>
> Attachments: hbase-12979-v0-master.patch
>
>
> In HBASE-5162 (and backports such as HBASE-12729) we modified some HRegion
> methods to return statistics for consumption by callers. The statistics are
> ultimately passed back to the client as load feedback.
> [~lhofhansl] thinks handing back this information as return values from
> HRegion methods is a weird mix of concerns. This also produced a difficult to
> anticipate binary compatibility issue with Phoenix. There was no compile time
> issue because the code of course was not structured to assign from a method
> returning void, yet the method signature changes so the JVM cannot resolve it
> if older Phoenix binaries are installed into a 0.98.10 release. Let's change
> the HRegion methods back to returning 'void' and use setters instead.
> Officially we don't support use of HRegion (HBASE-12566) but we do not need
> to go out of our way to break things (smile) so I would also like to make a
> patch release containing just this change to help out our sister project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
