[ 
https://issues.apache.org/jira/browse/HBASE-11567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310302#comment-14310302
 ] 

Enis Soztutar commented on HBASE-11567:
---------------------------------------

Can you change this following: 
{code}
+    WALKey key = new WALKey(info.getEncodedNameAsBytes(), tn);
{code}

to 
{code}
    // we use HLogKey here instead of WALKey directly to support legacy 
coprocessors.
    WALKey key = new HLogKey(info.getEncodedNameAsBytes(), tn);
{code}
The other similar methods in WALUtil (writeCompactionMarker) does that. Other 
than that +1. 
I have checked the PB refactor I was talking about earlier. It seems it is 
compatible in wire format, and I also tried manually serializing and 
deserializing with this change.  


> Write bulk load COMMIT events to WAL
> ------------------------------------
>
>                 Key: HBASE-11567
>                 URL: https://issues.apache.org/jira/browse/HBASE-11567
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Alex Newman
>         Attachments: HBASE-11567-v1.patch, HBASE-11567-v2.patch, 
> HBASE-11567-v4-rebase.patch, hbase-11567-v3.patch, hbase-11567-v4.patch
>
>
> Similar to writing flush (HBASE-11511), compaction(HBASE-2231) to WAL and 
> region open/close (HBASE-11512) , we should persist bulk load events to WAL.
> This is especially important for secondary region replicas, since we can use 
> this information to pick up primary regions' files from secondary replicas.
> A design doc for secondary replica replication can be found at HBASE-11183.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to