[ 
https://issues.apache.org/jira/browse/HBASE-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318265#comment-14318265
 ] 

Sean Busbey commented on HBASE-13027:
-------------------------------------

[~sduskis] thanks for the offer, but I already have tests done and am getting 
the fix in place.

I'm not sure what the rationalization is on having Admin require an unmanaged 
connection. I'm guessing that the Admin implementation retains a reference to 
the Connection and thus can't have it be managed since the user might keep a 
reference to the Admin instance while returning the Connection to the managed 
pool. (but I haven't looked at the code).

Since this is fixed in 2.0 while leaving the getAdmin check in place I think 
it's fine.

> Deprecated mapreduce.TableInputFormatBase initialization always fails
> ---------------------------------------------------------------------
>
>                 Key: HBASE-13027
>                 URL: https://issues.apache.org/jira/browse/HBASE-13027
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 1.0.0, 1.1.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>              Labels: hive
>             Fix For: 1.0.0, 1.1.0
>
>
> Folks extending the mapreduce.TableInputFormatBase class and relying on the 
> 0.98 way of doing table initialization (as given in the example in the 
> javadoc) will currently always get an error.
> When taking in a HTable, the current implementation retrieves a Connection 
> instance from the table and then an Admin instance from said Connection. The 
> getAdmin call validates that it only is called on unmanaged connections, but 
> when folks construct an HTable instance according to the examples, it ends up 
> backed by a managed connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to