[
https://issues.apache.org/jira/browse/HBASE-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318859#comment-14318859
]
Enis Soztutar commented on HBASE-13030:
---------------------------------------
Yes, ScanMetrics should be public API. I had a comment somewhere in the scanner
when I was doing ClientSideRegionScanner.
Instead of Scan.getMetrics(), it should be ResultScanner.getMetrics(). The way
we carry the scan metrics from scanners and put it to Scan as an attribute is
not right.
You have to add a InterfaceStability as well. The unit test checking client
side classes will fail otherwise.
> [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get,
> Delete, etc., addColumn
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-13030
> URL: https://issues.apache.org/jira/browse/HBASE-13030
> Project: HBase
> Issue Type: Bug
> Components: Operability
> Affects Versions: 1.0.0
> Reporter: stack
> Assignee: stack
> Fix For: 1.0.0, 2.0.0, 1.1.0
>
> Attachments: 13030.txt
>
>
> These are some of the items raised by [~larsgeorge] looking at our API for
> first time in a long time trying to update examples in the HBase Book.
> 1. ScanMetrics used to be available with some gymnastics in old days. Now it
> is IA.private and to get at it from Scan context, you need to use private
> ProtobufUtils. This seems like useful advanced user utility that should not
> be shut down.
> 2. Put is not like the others around the addColumn usage. Fix.
> [~enis] Hopefully these ok to go in (the Scan class addition is a little ugly
> but didn't want to do anything more adventurous this late in the game).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
