[ 
https://issues.apache.org/jira/browse/HBASE-12425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318868#comment-14318868
 ] 

Andrew Purtell commented on HBASE-12425:
----------------------------------------

Looks great. A couple of quick suggestions:

bq. After each flush or compaction finishes, a region split request is enqueued 
if the _region split policy_ determines that the region should be split into 
two.
After each flush or compaction finishes, the amount of data stored in the 
region has changed. The regionserver consults the _region split policy_ to 
determine if the region has grown too large or should be split for another 
policy-specific reason. A region split request is enqueued if the policy 
recommends it.

Above
bq. Since all data files in HBase are immutable,
consider:

Logically the process of splitting a region is simple. We find a suitable point 
in the keyspace of the region where we should divide the region in half, then 
split the region's data into two new regions at that point. The details of the 
process however are not simple. 

Finally, I suppose it's fine but I wonder if there is a way to explicitly set 
numbers in a numbered list. Otherwise an edit to the text might accidentally 
make the list numbering go out of sync with the diagram. 

> Document the phases of the split transaction
> --------------------------------------------
>
>                 Key: HBASE-12425
>                 URL: https://issues.apache.org/jira/browse/HBASE-12425
>             Project: HBase
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: Andrew Purtell
>            Assignee: Misty Stanley-Jones
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12425.patch, region_split_process.png
>
>
> See PDF document attached to parent issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to