[
https://issues.apache.org/jira/browse/HBASE-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113404#comment-13113404
]
Lars George commented on HBASE-4243:
------------------------------------
Oh, and I am for adding a prefix to the print out of the HADOOP_HOME, since
currently the echo only emits the selected path. In the context of the rest of
the console output this might be misleading. Maybe a Tomcat like printout would
be OK? For example:
echo "Using HADOOP_HOME: $HADOOP_HOME"
> HADOOP_HOME should be auto-detected
> -----------------------------------
>
> Key: HBASE-4243
> URL: https://issues.apache.org/jira/browse/HBASE-4243
> Project: HBase
> Issue Type: Improvement
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Priority: Minor
> Attachments: HBASE-4243-2.patch.txt, HBASE-4243.patch.txt
>
>
> Now that HBASE-3465 has been integrated, perhaps we should try to auto-detect
> the HADOOP_HOME setting if it is not given explicitly. Something along the
> lines of:
> {noformat}
> # check for hadoop in the path
> 141 HADOOP_IN_PATH=`which hadoop 2>/dev/null`
> 142 if [ -f ${HADOOP_IN_PATH} ]; then
> 143 HADOOP_DIR=`dirname "$HADOOP_IN_PATH"`/..
> 144 fi
> 145 # HADOOP_HOME env variable overrides hadoop in the path
> 146 HADOOP_HOME=${HADOOP_HOME:-$HADOOP_DIR}
> 147 if [ "$HADOOP_HOME" == "" ]; then
> 148 echo "Cannot find hadoop installation: \$HADOOP_HOME must be set or
> hadoop must be in the path";
> 149 exit 4;
> 150 fi
> {noformat}
> Thoughts?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira