[ https://issues.apache.org/jira/browse/HBASE-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321693#comment-14321693 ]
Hadoop QA commented on HBASE-13028: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698926/HBASE-13028.5.patch.txt against master branch at commit 332515ed346e1ffc104ce3bac986bb7030747a03. ATTACHMENT ID: 12698926 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12856//console This message is automatically generated. > Cleanup mapreduce API changes > ----------------------------- > > Key: HBASE-13028 > URL: https://issues.apache.org/jira/browse/HBASE-13028 > Project: HBase > Issue Type: Bug > Components: mapreduce > Affects Versions: 1.0.0 > Reporter: Sean Busbey > Assignee: Sean Busbey > Priority: Blocker > Labels: api > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-13028.1.patch.txt, HBASE-13028.2.patch.txt, > HBASE-13028.3.patch.txt, HBASE-13028.4.patch.txt, HBASE-13028.5.patch.txt > > > The API changes made in HBASE-12798 need to be cleaned up so their common use > makes more sense. > * initialize should take some kind of configuration object that can be used > in setting up a Connection (e.g. JobConf) > * initialize should be called at the start of getSplits and getRecordReader > rather than across the class when a member is needed > * the same changes should be present in the mapred package since it is not > longer deprecated > * examples should rely on idiomatic MapReduce (specifically they should not > be relying on JobConfigurable to get a JobConf instance) -- This message was sent by Atlassian JIRA (v6.3.4#6332)