[ https://issues.apache.org/jira/browse/HBASE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322423#comment-14322423 ]
Jingcheng Du commented on HBASE-12412: -------------------------------------- Thanks Misty. Why do we introduce some many other changes (coprocessor related) into this patch? In the hbase_apis.adoc, I think we still need a few changes. 1. The column family "NEWCF" is not existing, we could not use modifyFamily instead of addColumn. Let's keep this line the same as now ( still use addColumn). 2. Directly add these following code after the line of addColumn. {code} HColumnDescriptor existingColumn = new HColumnDescriptor(CF_DEFAULT); existingColumn.setCompactionCompressionType(Algorithm.GZ); existingColumn.setMaxVersions(HConstants.ALL_VERSIONS); table_assetmeta.modifyFamily(existingColumn) admin.modifyTable(tableName, table_assetmeta); {code} How about this? > update the ref guide(currently Example 10.2) to show "update an existing CF" > with the new API modifyFamily in master > -------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-12412 > URL: https://issues.apache.org/jira/browse/HBASE-12412 > Project: HBase > Issue Type: Bug > Components: documentation > Reporter: Jingcheng Du > Assignee: Misty Stanley-Jones > Priority: Minor > Attachments: HBASE-12412-v1.patch, HBASE-12412.patch > > > In the new implementation of HTableDescriptor, updating an existing CF > doesn't use the addFamily any more(An IllegalArgumentException is thrown in > such a case.), the new API modifyFamily is used instead. > We need to update the ref guide (currently Example 10.2) to show "update an > existing CF" with the new API modifyFamily in master. -- This message was sent by Atlassian JIRA (v6.3.4#6332)