[ 
https://issues.apache.org/jira/browse/HBASE-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113569#comment-13113569
 ] 

Kannan Muthukkaruppan commented on HBASE-4434:
----------------------------------------------

Jonathan: Thanks for the review!

Unit tests ran fine, but for some completely unrelated/env related failures. 
 org.apache.hadoop.hbase.avro.TestAvroServer: Unresolved compilation problem:
  testThreeRSAbort(org.apache.hadoop.hbase.master.TestDistributedLogSplitting): 
test timed out after 300000 milliseconds
  
testOrphanLogCreation(org.apache.hadoop.hbase.master.TestDistributedLogSplitting):
 test timed out after 300000 milliseconds
  
testStatusTemplateNoTables(org.apache.hadoop.hbase.master.TestMasterStatusServlet):
 Unresolved compilation problems:

Can someone commit? (I will submit patch for HBASE-4433 after the commit since 
that patch will update the TestBlocksRead again).

> Don't do HFile Scanner next() unless the next KV is needed:
> -----------------------------------------------------------
>
>                 Key: HBASE-4434
>                 URL: https://issues.apache.org/jira/browse/HBASE-4434
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> When a seek/reseek is done on StoreFileScanner, in addition to setting the 
> current KV, it also does a HFileScanner level next() ahead of time even if 
> the next KV is never actually required. This inefficiency can potentially 
> result in additional disk seeks and sub-optimal use of the block cache 
> (primarily for cases where the KVs are large and each occupies an HFile block 
> of its own).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to