[
https://issues.apache.org/jira/browse/HBASE-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325795#comment-14325795
]
Hadoop QA commented on HBASE-13061:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12699400/HBASE-13061.patch
against master branch at commit 7b045d143ab91089c1c13f3095389fb5de4111f5.
ATTACHMENT ID: 12699400
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.hadoop.hbase.coprocessor.TestMasterObserver.testRegionTransitionOperations(TestMasterObserver.java:1604)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12891//console
This message is automatically generated.
> RegionStates can remove wrong region from server holdings
> ---------------------------------------------------------
>
> Key: HBASE-13061
> URL: https://issues.apache.org/jira/browse/HBASE-13061
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Andrey Stepachev
> Assignee: Andrey Stepachev
> Attachments: HBASE-13061.patch
>
>
> Got failed test in HBASE-13017. It seems that with zk nodes were ordered in
> one way and test didn't trigger error, but with new meta rows ordered
> differently test became flakey.
> That leads to interesting sequence of offline/online regions and triggers bug
> and NPE in AM (thats seen in TestZKLessAMOnCluster)
> That can happen if region was moved from RS1 to other region server RS2, and
> thats happens that RS2 failed. Region remains in PENDING_OPEN. SSH will
> offline it from RS1(without removing from oldAssignments because of disabled
> table). When AssingnmentManager come and assign region it then removes
> oldAssignment of region from serverHoldings. And thats happen to be our just
> assigned RS1.
> Small bit of logs. Most interesting are last 3 lines, region
> b73fe9f1185361e846b0e1ceb7d6d64e added to server and immediately removed from
> it. Later that triggers NPE in disable table handler.
> {code}
> 2015-02-18 01:21:18,338 INFO [Thread-436] master.RegionStates(1109):
> Transition {b73fe9f1185361e846b0e1ceb7d6d64e state=PENDING_OPEN,
> ts=1424222478324, server=octobook.home,65370,1424222474885} to
> {b73fe9f1185361e846b0e1ceb7d6d64e state=OFFLINE, ts=1424222478338,
> server=octobook.home,65370,1424222474885}
> 2015-02-18 01:21:18,339 INFO [Thread-436] master.RegionStateStore(218):
> Updating row
> testSSHWhenDisablingTableRegionsInOpeningOrPendingOpenState,I,1424222477651.b73fe9f1185361e846b0e1ceb7d6d64e.
> with state=OFFLINE
> 2015-02-18 01:21:18,340 DEBUG [Thread-436] master.RegionStates(591): Old
> server name for {ENCODED => b73fe9f1185361e846b0e1ceb7d6d64e, NAME =>
> 'testSSHWhenDisablingTableRegionsInOpeningOrPendingOpenState,I,1424222477651.b73fe9f1185361e846b0e1ceb7d6d64e.',
> STARTKEY => 'I', ENDKEY => 'Q'} is null
> 2015-02-18 01:21:18,340 INFO [Thread-436] master.RegionStates(1109):
> Transition {b73fe9f1185361e846b0e1ceb7d6d64e state=OFFLINE, ts=1424222478338,
> server=octobook.home,65370,1424222474885} to
> {b73fe9f1185361e846b0e1ceb7d6d64e state=OPEN, ts=1424222478340,
> server=octobook.home,65359,1424222474743}
> 2015-02-18 01:21:18,341 INFO [Thread-436] master.RegionStateStore(218):
> Updating row
> testSSHWhenDisablingTableRegionsInOpeningOrPendingOpenState,I,1424222477651.b73fe9f1185361e846b0e1ceb7d6d64e.
> with state=OPEN&sn=octobook.home,65359,1424222474743
> 2015-02-18 01:21:18,342 DEBUG [Thread-436] master.RegionStates(457): Onlined
> b73fe9f1185361e846b0e1ceb7d6d64e on octobook.home,65359,1424222474743
> {ENCODED => b73fe9f1185361e846b0e1ceb7d6d64e, NAME =>
> 'testSSHWhenDisablingTableRegionsInOpeningOrPendingOpenState,I,1424222477651.b73fe9f1185361e846b0e1ceb7d6d64e.',
> STARTKEY => 'I', ENDKEY => 'Q'}
> 2015-02-18 01:21:18,342 DEBUG [Thread-436] master.RegionStates(481): Adding
> b73fe9f1185361e846b0e1ceb7d6d64e to server octobook.home,65359,1424222474743
> 2015-02-18 01:21:18,342 INFO [Thread-436] master.RegionStates(467): Offlined
> b73fe9f1185361e846b0e1ceb7d6d64e from octobook.home,65359,1424222474743
> 2015-02-18 01:21:18,342 DEBUG [Thread-436] master.RegionStates(496): Removing
> b73fe9f1185361e846b0e1ceb7d6d64e from server octobook.home,65359,1424222474743
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
