[ 
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326573#comment-14326573
 ] 

Matteo Bertozzi commented on HBASE-13063:
-----------------------------------------

{quote}Don't you think we should be setting the default flag to false?{quote}
nah, in theory you expect the replica to be quite up to date. 
this flag is just if your client can stay behind "a lot" and it is aware of 
that.

{quote} May be a good idea to initialize with null as you are checking for null 
in requiresReplication?{quote}
sure.. I'll add that. but null is the default value 
http://docs.oracle.com/javase/specs/jls/se7/html/jls-4.html#jls-4.12.5

{quote}Also, it would be a good idea to ad LOG statement saying whether 
memstore replication is enabled/disabled.{quote}
since we don't have a sink object for each table, it will require adding a set 
or something to print the log only once. not sure if it is worth.

> Allow to turn off memstore replication for region replicas
> ----------------------------------------------------------
>
>                 Key: HBASE-13063
>                 URL: https://issues.apache.org/jira/browse/HBASE-13063
>             Project: HBase
>          Issue Type: New Feature
>          Components: regionserver, Replication
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13063-v0.patch
>
>
> HBASE-11568 allows to use replication to send wal edits from the primary to 
> the replicas.
> sometimes the memstore replication is not required, so it will be nice have a 
> flag to disable it.
> the result will be more or less the same to what we have in phase-1, but with 
> the row-level consistency provided by the "flush" edit transfered via 
> replication to refresh the hfiles.
> create 't1', 'f', {REGION_REPLICATION => 2, REGION_MEMSTORE_REPLICATION => 
> false}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to