[ https://issues.apache.org/jira/browse/HBASE-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327189#comment-14327189 ]
Hadoop QA commented on HBASE-13056: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699640/HBASE-13056-0.98.patch against 0.98 branch at commit 31f17b17f0e2d12550b97098ec45ab59c5d98d58. ATTACHMENT ID: 12699640 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12908//console This message is automatically generated. > Refactor table.jsp code to remove repeated code and make it easier to add new > checks > ------------------------------------------------------------------------------------ > > Key: HBASE-13056 > URL: https://issues.apache.org/jira/browse/HBASE-13056 > Project: HBase > Issue Type: Improvement > Affects Versions: 2.0.0 > Reporter: Vikas Vishwakarma > Assignee: Vikas Vishwakarma > Fix For: 2.0.0 > > Attachments: HBASE-13056-0.98.patch, HBASE-13056.patch > > > While trying to fix HBASE-13001, I realized that there is lot of html code > repetition in table.jsp which is making addition of new checks slightly > difficult in the sense I will have to: > 1. Add the check at multiple places in the code > Or > 2. Repeat the html code again for the new check > So I am proposing to re-factor table.jsp code such that the common html > header/body is loaded without any condition check and then we generate the > condition specific html code > snapshot.jsp follows the same format as explained below: > {noformat} > Current implementation: > ==================== > if( x ) { > title_x > common_html_header > common_html_body > x_specific_html_body > } else { > title_y > common_html_header > common_html_body > y_specific_html_body > } > New Implementation: > ================== > if( x ) { > title_x > } else { > title_y > } > common_html_header > common_html_body > if( x ) { > x_specific_html_body > } else { > y_specific_html_body > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)