[ https://issues.apache.org/jira/browse/HBASE-13133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342644#comment-14342644 ]
zhangduo commented on HBASE-13133: ---------------------------------- This patch fix the NullPointer, and testOrphanTaskAcquisition does not fail any more. But testGetPreviousRecoveryMode is still failing with {noformat} java.lang.AssertionError: Mode4=LOG_SPLITTING at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.hadoop.hbase.master.TestSplitLogManager.testGetPreviousRecoveryMode(TestSplitLogManager.java:662) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) {noformat} > NPE when running TestSplitLogManager > ------------------------------------ > > Key: HBASE-13133 > URL: https://issues.apache.org/jira/browse/HBASE-13133 > Project: HBase > Issue Type: Bug > Reporter: zhangduo > Assignee: Andrey Stepachev > Attachments: HBASE-13133.patch > > > https://builds.apache.org/job/HBase-TRUNK/6187/testReport/junit/org.apache.hadoop.hbase.master/TestSplitLogManager/testOrphanTaskAcquisition/ > {noformat} > 2015-03-01 01:34:58,902 INFO [Thread-23] master.TestSplitLogManager(298): > TestOrphanTaskAcquisition > 2015-03-01 01:34:58,904 DEBUG [Thread-23] > coordination.ZKSplitLogManagerCoordination(870): Distributed log replay=true > 2015-03-01 01:34:58,907 INFO [Thread-23] > coordination.ZKSplitLogManagerCoordination(594): found orphan task > orphan%2Ftest%2Fslash > 2015-03-01 01:34:58,913 INFO [Thread-23] > coordination.ZKSplitLogManagerCoordination(598): Found 1 orphan tasks and 0 > rescan nodes > 2015-03-01 01:34:58,913 ERROR [main-EventThread] > zookeeper.ClientCnxn$EventThread(613): Caught unexpected throwable > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coordination.ZKSplitLogManagerCoordination.findOrCreateOrphanTask(ZKSplitLogManagerCoordination.java:546) > at > org.apache.hadoop.hbase.coordination.ZKSplitLogManagerCoordination.heartbeat(ZKSplitLogManagerCoordination.java:556) > at > org.apache.hadoop.hbase.coordination.ZKSplitLogManagerCoordination.getDataSetWatchSuccess(ZKSplitLogManagerCoordination.java:467) > at > org.apache.hadoop.hbase.coordination.ZKSplitLogManagerCoordination.access$700(ZKSplitLogManagerCoordination.java:74) > at > org.apache.hadoop.hbase.coordination.ZKSplitLogManagerCoordination$GetDataAsyncCallback.processResult(ZKSplitLogManagerCoordination.java:1020) > at > org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:561) > at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498) > {noformat} > I got this NPE almost every time when running TestSplitLogManager locally. I > am not sure whether it is the root cause of test failing, but seems related. -- This message was sent by Atlassian JIRA (v6.3.4#6332)