[ https://issues.apache.org/jira/browse/HBASE-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344238#comment-14344238 ]
Hadoop QA commented on HBASE-11580: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702007/hbase-11580_v3.patch against master branch at commit 74e36f8ddd03cf94c17bdb30ecd81cc5dff4d063. ATTACHMENT ID: 12702007 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 23 new or modified tests. {color:red}-1 Anti-pattern{color}. The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: + getRegionInfo(), -1, new TreeMap<byte[], List<Path>>());. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3 warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13043//console This message is automatically generated. > Failover handling for secondary region replicas > ----------------------------------------------- > > Key: HBASE-11580 > URL: https://issues.apache.org/jira/browse/HBASE-11580 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Attachments: hbase-11580_v2.patch, hbase-11580_v3.patch > > > With the async wal approach (HBASE-11568), the edits are not persisted (to > wal) in the secondary region replicas. However this means that we have to > deal with secondary region replica failures. > We can seek to re-replicate the edits from primary to the secondary when the > secondary region is opened in another server but this would mean to setup a > replication queue again, and holding on to the wals for longer. > Instead, we can design it so that the edits form the secondaries are not > persisted to wal, and if the secondary replica fails over, it will not start > serving reads until it has guaranteed that it has all the past data. > For guaranteeing that the secondary replica has all the edits before serving > reads, we can use flush and region opening markers. Whenever a region open > event is seen, it writes all the files at the time of opening to wal > (HBASE-11512). In case of flush, the flushed file is written as well, and the > secondary replica can do a ls for the store files and pick up all the files > before the seqId of the flushed file. So, in this design, the secodary > replica will wait until it sees and replays a flush or region open marker > from wal from primary. and then start serving. For speeding up replica > opening time, we can trigger a flush to the primary whenever the secondary > replica opens as an optimization. -- This message was sent by Atlassian JIRA (v6.3.4#6332)