[ https://issues.apache.org/jira/browse/HBASE-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348867#comment-14348867 ]
Sean Busbey commented on HBASE-13128: ------------------------------------- please fix these two checkstyle errors: {noformat} <file name="/Users/busbey/projects/hbase-priority/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java"> <error line="202" column="63" severity="error" message="File contains tab characters (this is the first instance)." source="com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck"/> <error line="321" severity="error" message="Line is longer than 100 characters (found 122)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/> {noformat} The tab warning only prints for the first occurrence, so you should check for more tabs elsewhere in the patch. > Make HBCK's lock file retry creation and deletion > ------------------------------------------------- > > Key: HBASE-13128 > URL: https://issues.apache.org/jira/browse/HBASE-13128 > Project: HBase > Issue Type: Improvement > Components: hbck > Reporter: Victoria > Assignee: Victoria > Priority: Minor > Attachments: hbck_files_fix-v1.patch, hbck_files_fix-v2.patch, > hbck_files_fix-v3.patch, hbck_files_fix.patch > > > When hbck runs it creates a lock file to ensure that no two hbck instances > are running. We've been seeing creating and removing that file fail sometimes. > This improvement should make the creation, closing of the file, and the > deletion retry multiple times. This should allow our alerting which uses this > command to be more reliable and have fewer false positives. -- This message was sent by Atlassian JIRA (v6.3.4#6332)