[ https://issues.apache.org/jira/browse/HBASE-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349313#comment-14349313 ]
Jimmy Xiang commented on HBASE-13076: ------------------------------------- I remember that the code removed in this patch is initially introduced in HBASE-5155 (later on changed a little in HBASE-6229). At that time, we had a some problem to tell if a table is enabled if it is already enabled. For this issue, I think we can remove the code, or fail the assignment if the table is not enabled/enabling. I prefer to remove the code since the table state is checked later anyway (and the change is simpler/safer). (Note: If we fail the assignment now, it is good, but we need to update the state accordingly. That's some enhancement. If this doesn't happen a lot, we may not need the enhancement.) > Table can be forcibly enabled in AssignmentManager during table disabling. > -------------------------------------------------------------------------- > > Key: HBASE-13076 > URL: https://issues.apache.org/jira/browse/HBASE-13076 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment > Affects Versions: 2.0.0 > Reporter: Andrey Stepachev > Assignee: Andrey Stepachev > Attachments: 23757f039d83f4f17ca18815eae70b28.log, HBASE-13076.patch > > > Got situation where region can be opened while table is disabling by > DisableTableHandler. Here is relevant log for such situation. There is no > clues who issued OPEN to region. > Log file attached. > UPD: A bit more details. It seems that even in case of new state put into > meta, it still possible to get previous state. > That leads to one more round of assignment invoked in > AssignmentManager#onRegionClosed. > UPD: Table become ENABLED, thats leads to regions instructed to assign > immediately on onRegionClosed. BulkDisabler will not know about that and will > wait indefinitely, because it will not issue unassign for newly opened > regions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)