[ https://issues.apache.org/jira/browse/HBASE-13109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362243#comment-14362243 ]
Lars Hofhansl commented on HBASE-13109: --------------------------------------- Ultimately I only need this method in: KeyValueHeap, StoreScanner, StoreFileScanner, and AbstractHFileReader.Scanner. But doing only would litter class casts all over the code along with class checks in hot code paths. I do not think that makes sense. So, we can undo this from 0.98 altogether. (but -1 on that from me). Or we can delay this until 0.98.13. By then Phoenix needs to have new minor versions of 4.2 and 4.3. I'd be +0 on that. And just in case, -1 on delaying this further than 0.98.13... > Make better SEEK vs SKIP decisions during scanning > -------------------------------------------------- > > Key: HBASE-13109 > URL: https://issues.apache.org/jira/browse/HBASE-13109 > Project: HBase > Issue Type: Improvement > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 > > Attachments: 13109-0.98-v4.txt, 13109-trunk-v2.txt, > 13109-trunk-v3.txt, 13109-trunk-v4.txt, 13109-trunk-v5.txt, 13109-trunk.txt, > nextIndexKVChange_new.patch > > > I'm re-purposing this issue to add a heuristic as to when to SEEK and when to > SKIP Cells. This has come up in various issues, and I think I have a way to > finally fix this now. HBASE-9778, HBASE-12311, and friends are related. > --- Old description --- > This is a continuation of HBASE-9778. > We've seen a scenario of a very slow scan over a region using a timerange > that happens to fall after the ts of any Cell in the region. > Turns out we spend a lot of time seeking. > Tested with a 5 column table, and the scan is 5x faster when the timerange > falls before all Cells' ts. > We can use the lookahead hint introduced in HBASE-9778 to do opportunistic > SKIPing before we actually seek. -- This message was sent by Atlassian JIRA (v6.3.4#6332)